creativecommons / creativecommons.org

Legacy legal code translations and general support issues
MIT License
156 stars 204 forks source link

Top navigation missing on some license pages #990

Closed kgodey closed 5 years ago

kgodey commented 5 years ago

Email received from user:

When viewing the deeds like https://creativecommons.org/licenses/by-nc/4.0/ there is a header with "Share your work Use & remix What we do Blog" etc. But when switching to some languages like danish: https://creativecommons.org/licenses/by-nc/4.0/deed.da The header is not there. I suggest to make it the same for all languages.

TimidRobot commented 5 years ago

Explanation

This was a choice made (maybe unintentionally) by the translation team/volunteers. See

  1. creativecommons/cc.engine: /cc/engine/templates/macros_templates/deed.html: Line 53
    {# Translators: Change hide-banner to an empty string to show the complete site header and footer #}
    • Note: many languages (see below) have translated "hide-banner", which results in the banner being shown. Only the English string "hide-banner" hides the banner.
  2. creativecommons/cc.i18n: /cc/i18n/po/da/cc_org.po: Line 3302
    msgstr "hide-banner"

hide-banner string statistics

Item Count
cc.i18n po files: 131
empty string: 110
non-empty string: 21

Translations with non-empty string

TimidRobot commented 5 years ago

Pull request opened to address this within creativecommons/cc.engine. I also reached out via email and will add any relevant correspondence to this ticket.