search

creativecommons / index-prototype

This is the UX frontend prototyping repository for the new creativecommons.org website build, inspired by the Vocabulary design system.
https://creativecommons-prototype.netlify.app/
Creative Commons Zero v1.0 Universal
5 stars 9 forks source link

Favicon and app icons not present on website #6

Closed Lakshay-Pruthi closed 7 months ago

Lakshay-Pruthi commented 1 year ago

Description

Favicon not present on website.

Reproduction

  1. Go to website
  2. See error.

Expectation

There should be a favicon.

Resolution

TimidRobot commented 1 year ago

The required files can be found in the creativecommons/search repository. See:

possumbilities commented 1 year ago

@Lakshay-Pruthi The favicons and app Icons are currently missing intentionally while it's sorted out the best way to utilize them going forward. A lot of the existing use-cases need to be vetted before we go forward rather than continuing with what we've done in existing repositories.

One way you could help move this forward would be to see what the current recommended standards are for this area of implementation and list them here as a comment. (Also anyone else in the community can do the same if you see this!) As with anything I would assume there's some variation and it's worth listing any variations and their merits so a decision can be reached about their use.

Moving to a status: blocked until a route is outlined and agreed upon forward.

It's good that this Issue was added, because it documents that this is missing and gives us a place to discuss how it'll be implemented going forward.

If in the end the results are that what we've been doing is fine to continue with then we'll move to to status: ready for work and proceed, which is why I'm leaving #8 open for now :)

Lakshay-Pruthi commented 1 year ago

@possumbilitiesI I don't think there are any kind of fixed standards for the usage. I would recommend using multiple sizes of the app icon so that it looks good on all devices and a transparent background for the icon to ensure it looks good on different backgrounds as well.

possumbilities commented 7 months ago

Completed by #49