creativecommons / legaldb

CC Legal Database: curated repository of Case Law and Scholarship data from around the world in a Django based website.
https://LegalDB.CreativeCommons.org/
MIT License
44 stars 54 forks source link

Added spacing between ADD LINK and SUBMIT CASE buttons #154

Closed justaskulkarni closed 1 year ago

justaskulkarni commented 1 year ago

Fixes

Fixes #149 by @justaskulkarni

Description

There is no margin between the 'Add Link' and 'Submit Case' buttons. Add Link buttons is aligned to the right and therefore, it doesn't cause an issue on larger screens. However on smaller screens, the lack of a margin is clearly noticeable.

Cause of the Error When the is-pulled-right class is removed, we obtain the desired spacing. However, as expected, the 'Add Link' is no longer aligned to the right.

Course of Action Identified a way to align the 'Add Link' button to the right without the use of is-pulled-right class.

Solution buttons.is-right can be used to align the 'Add Link' button to the right.

Tests

https://user-images.githubusercontent.com/98650743/230157490-ea6d7dcf-c6db-4874-9c18-fab708b07698.mp4

Checklist

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin ``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```
justaskulkarni commented 1 year ago

It's the same as #150 which got closed because I deleted my branch by mistake. Sorry for the inconvenience

TimidRobot commented 1 year ago

Deployed to Production

Per deploy_to_heroku.md:

git push heroku main
Enumerating objects: 28, done.
Counting objects: 100% (28/28), done.
Delta compression using up to 10 threads
Compressing objects: 100% (20/20), done.
Writing objects: 100% (20/20), 4.11 KiB | 4.11 MiB/s, done.
Total 20 (delta 9), reused 0 (delta 0), pack-reused 0
remote: Updated 62 paths from cfcf5e6
remote: Compressing source files... done.
remote: Building source:
remote: 
remote: -----> Building on the Heroku-22 stack
remote: -----> Using buildpack: heroku/python
remote: -----> Python app detected
remote: -----> Using Python version specified in Pipfile.lock
remote: -----> Python version has changed from python-3.10.10 to python-3.10.11, clearing cache
remote: -----> Installing python-3.10.11
remote: -----> Installing pip 23.0.1, setuptools 67.6.1 and wheel 0.40.0
remote: -----> Installing dependencies with Pipenv 2023.2.4
remote:        Installing dependencies from Pipfile.lock (b26e88)...
remote: -----> Installing SQLite3
remote: -----> $ python manage.py collectstatic --noinput
remote:        397 static files copied to '/tmp/build_001d4e56/staticfiles', 705 post-processed.
remote: 
remote: -----> Discovering process types
remote:        Procfile declares types -> release, web
remote: 
remote: -----> Compressing...
remote:        Done: 57.9M
remote: -----> Launching...
remote:  !     Release command declared: this new release will not be available until the command succeeds.
remote:        Released v41
remote:        https://fast-eyrie-10628.herokuapp.com/ deployed to Heroku
remote: 
remote: Verifying deploy... done.
remote: Running release command...
remote: 
remote: Operations to perform:
remote:   Apply all migrations: admin, auth, contenttypes, legal_db, sessions, taggit
remote: Running migrations:
remote:   No migrations to apply.
remote: Waiting for release.... done.
To https://git.heroku.com/fast-eyrie-10628.git
   220dc4f..c5be63d  main -> main