creativecommons / legaldb

CC Legal Database: curated repository of Case Law and Scholarship data from around the world in a Django based website.
https://LegalDB.CreativeCommons.org/
MIT License
44 stars 54 forks source link

[Feature] Header isn't consistent with the current Vocabulary design system #195

Open Netacci opened 5 days ago

Netacci commented 5 days ago

Problem

The header design implemented does not match the current Vocabulary design system. It is also missing the Explore CC drop down.

Legaldb website

legal-head

Vocabulary design system

b-h

Description

There is a noticeable difference in the header layout and styling between what is defined in the design system and what is implemented on the legaldb website.

The header in the legaldb website should be center aligned to match what we have in the design system. We should also include the Explore CC dropdown and navigation section.

Additional context

Implementation

Poison-Iveey commented 3 days ago

Hi, @Netacci and @TimidRobot , I am working on this

Queen-codes commented 2 days ago

hi @TimidRobot and @possumbilities I hope you are both having a great weekend.

I have started working on this issue and would like your input and suggestions before I proceed further than I already have. Currently, I have two approaches to fixing this issue.

The first option is to lift the CSS styles directly from Vocabulary and add them to the legal db CSS file, which could allow for quicker implementation and fixing of this issue.

The other option is to install the current version of Vocabulary in the codebase to maintain a consistent design system and make future updates easier. This might also be a solution to issue #196. If vocabulary is included, both issues can be fixed quickly.

I'd appreciate any insight on which approach is better. I look forward to hearing from you when office hours are open. Enjoy the rest of your weekend.