creativecommons / legaldb

CC Legal Database: curated repository of Case Law and Scholarship data from around the world in a Django based website.
https://LegalDB.CreativeCommons.org/
MIT License
46 stars 69 forks source link

[Bug] Deprecation Warnings Encountered When Running npm run watch for Sass on LegalDB #203

Open Netacci opened 1 month ago

Netacci commented 1 month ago

Description

When running npm run watch to watch Sass locally on the LegalDB project, deprecation warnings are encountered. These warnings suggest that certain features are deprecated and need to be updated to avoid potential issues in the future.

Reproduction

  1. Run the Sass watcher with `npm run watch`
  2. See error. See deprecation warnings in the terminal.

Expectation

The Sass watcher should run without any deprecation warnings, indicating that all features used are up-to-date and compliant with the latest standards.

Screenshots

nth behavorp

divide rule

Environment

Additional context

The specific deprecation warnings point to outdated Sass syntax that need to be refactored to align with newer versions of Sass

see below

https://sass-lang.com/documentation/breaking-changes/slash-div/

https://sass-lang.com/documentation/breaking-changes/mixed-decls/

Resolution

TimidRobot commented 1 month ago

https://github.com/creativecommons/legaldb/labels/%F0%9F%9A%A7%20status%3A%20blocked by need to migrate to the current Vocabulary design system:

Netacci commented 1 month ago

Hi @TimidRobot to implement vocabulary on legal db, does that mean we'll be changing the styling implementation to use css instead of scss?

TimidRobot commented 1 month ago

@Netacci Probably, but I'm not sure.

Netacci commented 1 month ago

That might be the move. It's either that or having to directly compile vocabulary css directly into scss file(which I've tried and experiencing errors) or converting vocabulary css to scss @TimidRobot