[Fix] Missing Form Method on <form> Element in _search.html

[wendy640]

Fixes

• Fixes #211 by @wendy640

Description

This pull request fixes an issue where the method attribute was incorrectly placed on a 'div' element instead of the 'form' element in the search functionality. This misplacement could lead to unexpected behavior during form submission. The fix ensures proper HTML standards are followed by relocating the method="get" attribute to the 'form' element.

Technical details

1. Moved the method="get" attribute from <div> to <form> within the _search.html file.
2. Ensured that the form is now correctly structured for proper submission behavior.

Tests

Screenshots

Checklist

• [x] My pull request has a descriptive title (not a vague title like Update index.md).
• [x] My pull request targets the default branch of the repository (main or master).
• [x] My commit messages follow best practices.
• [x] My code follows the established code style of the repository.
• [ ] I added or updated tests for the changes I made (if applicable).
• [ ] I added or updated documentation (if applicable).
• [x] I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin

``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```

[wendy640]

@TimidRobot thank you for the feedback, the requested changes has been affected. i will await more feedbacks. thanks again.

[wendy640]

@TimidRobot, thank you for the feedback, the requested changes has been affected. thanks again.

[TimidRobot]

Deployed to production

See https://github.com/creativecommons/legaldb/pull/241#issuecomment-2422771467

[TimidRobot]

@wendy640 My apologies, did not provide very good guideance:

• 246:

  • What I didn't realize is that the _search.html template fragment is called from:
    • https://github.com/creativecommons/legaldb/blob/475900b7567465a5489d8b6bf96b575443260a5d/legal_db/templates/legal_db/case/index.html#L26-L27
    • (note <form opening tag)
    • https://github.com/creativecommons/legaldb/blob/475900b7567465a5489d8b6bf96b575443260a5d/legal_db/templates/legal_db/scholarship/index.html#L26-L27
    • (note <form opening tag)
  • the PR added a second <form> tag with the existing <form>

[wendy640]

okay, thank you