creativecommons / legaldb

CC Legal Database: curated repository of Case Law and Scholarship data from around the world in a Django based website.
https://LegalDB.CreativeCommons.org/
MIT License
46 stars 69 forks source link

[Fix] Title Heading Misalignment on Larger Screens #225

Closed wendy640 closed 1 month ago

wendy640 commented 1 month ago

Fixes

Description

This pull request resolves the misalignment issue of the "Explore by content" heading on larger screens. The heading was not centrally aligned and did not appear directly above the associated content, causing an inconsistent visual layout. The fix adjusts the HTML to ensure the heading is centered and aligned properly, creating a more consistent layout across all screen sizes.

Technical details

The alignment issue was resolved by restructuring the HTML to use centered columns `

Explore by content

    </div>`

Tests

  • Open the affected page on a larger screen (e.g., 1920x1080 resolution).

  • Verify that the "Explore by content" heading is now centrally aligned and positioned directly above the related content (case tags and scholarship tags).

  • Confirm that the padding below the heading creates the intended visual separation, improving readability.

Screenshots

Before Screen Shot 2024-10-09 at 7 37 39 PM

After Screen Shot 2024-10-15 at 2 16 54 PM

Checklist

  • [x] My pull request has a descriptive title (not a vague title like Update index.md).
  • [x] My pull request targets the default branch of the repository (main or master).
  • [x] My commit messages follow best practices.
  • [x] My code follows the established code style of the repository.
  • [x] I added or updated tests for the changes I made (if applicable).
  • [x] I added or updated documentation (if applicable).
  • [x] I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin ``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```
TimidRobot commented 1 month ago

@wendy640, I'm sorry that I've wasted your time. I realized the underlying issue was invalid.