creativecommons / legaldb

CC Legal Database: curated repository of Case Law and Scholarship data from around the world in a Django based website.
https://LegalDB.CreativeCommons.org/
MIT License
46 stars 69 forks source link

[Bug] Card component disappears in smaller screen sizes. #231

Closed SumaiyaaRq closed 1 month ago

SumaiyaaRq commented 1 month ago

Description

In the CC Legal DataBase ,the CaseLaw Database component that leads to Cases page, the card component named "contribute-card" disappears on smaller screen sizes ,specifically below 1024 pixels of width.

Reproduction

  1. Open the CC Legal DataBase page.
  2. Go to cases.
  3. View the page for smaller screen size
  4. See error.

Expectation

The contribute card component of the page should remain intact in all screen sizes. When a card disappears it may lead to issues affecting user experience, functionality, and usability. Addressing this issue would ensure better responsiveness and accessibility across devices.

Screenshots

Screenshot 2024-10-16 at 5 53 15 PM Screenshot 2024-10-16 at 5 54 45 PM

Environment

Additional context

A similar issue can be seen with the Scholarship page where the contribute-card disappears at smaller width.

Resolution

Vanessa082 commented 1 month ago

@SumaiyaaRq @TimidRobot I did a pr could you check it out would be glad to get your feedback

SumaiyaaRq commented 1 month ago

@SumaiyaaRq @TimidRobot I did a pr could you check it out would be glad to get your feedback

@Vanessa082 I really appreciate your efforts put into resolving this issue ! The attached recording shows that the responsiveness issue has been resolved . I noticed changes to the .gitignore file & package.json file . In my opinion , generally , modifying.gitignore file & package.json file is not necessary to fix responsiveness issues. Could you please clarify why these changes were made? If they aren't essential for the fix , it might be better to keep these files as they are to maintain consistency across the project. Looking forward to your thoughts!

However , @TimidRobot being our mentor, has the final saying on these changes.

SumaiyaaRq commented 1 month ago

@SumaiyaaRq thanks for bringing it to my knowledge I will check honestly can not remember making changes there that is the gitignore I did ignore the vscode I do not thing it is bad file and for the package, I think it is because I installed web pack

@Vanessa082 You are welcome! As you said , it can be possible that installing a web pack has caused those changes . A suggestion from my side , before committing to any changes , you can run the command git status in your working branch to see if any files have been modified. If there are any automatic changes (like formatting or generated code) to a file , they will show up . This might help you spot unintended modifications in future!

TimidRobot commented 1 month ago

@SumaiyaaRq thank you for your review contributions in the comments above!

SumaiyaaRq commented 1 month ago

Thank you so much!@TimidRobot Glad I could help!