creativecommons / legaldb

CC Legal Database: curated repository of Case Law and Scholarship data from around the world in a Django based website.
https://LegalDB.CreativeCommons.org/
MIT License
46 stars 69 forks source link

Added ARIA attributes to essential elements #232

Open SisiVero opened 1 month ago

SisiVero commented 1 month ago

Fixes

Description

The PR addresses the issue of adding ARIA attributes to essential components relative to legaldb.

Technical details

The footer and header files were untouched as changes from the vocabulary will be effected in it.

Checklist

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin ``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```
SisiVero commented 1 month ago

Please resolve conflicts and remove whitespace changes (you've replaced unix LF line endings with Windows CRLF line endings)

I'll resolve them asap. Thank you

SisiVero commented 1 week ago

@TimidRobot noted. Changes will be effected and committed. Thank you.

SisiVero commented 1 week ago

@TimidRobot noted. Changes will be effected and committed. Thank you.

This might take a little while as I would love to go through the contents of the link you provided, as it would help me understand better what to do and not to do when adding ARIA attributes.

SisiVero commented 6 days ago

Please:

  1. reduce the changes so that there isn't duplication of existing elements/text

    • ARIA - Accessibility | MDN

      The first rule of ARIA use is "If you can use a native HTML element or attribute with the semantics and behavior you require already built in, instead of re-purposing an element and adding an ARIA role, state or property to make it accessible, then do so."

  2. Resolve conflicts with main branch

  3. Add support for translation for added strings, where appropriate

Hi @TimidRobot , Corrections have been effected as requested. Do review when you can. Thank you.

SisiVero commented 3 days ago

Very close! Just a few small changes

Hi @TimidRobot Changes have been effected. Do confirm when you can. Thank you