creativecommons / legaldb

CC Legal Database: curated repository of Case Law and Scholarship data from around the world in a Django based website.
https://LegalDB.CreativeCommons.org/
MIT License
45 stars 69 forks source link

[Feature] Standardize LegalDB Logo Format According to Vocabulary Guidelines #254

Open rypptc opened 3 weeks ago

rypptc commented 3 weeks ago

Problem

The logo on the legaldb page is not in line with the examples described in Vocabulary, (index-logo.html and product-logo.html). This causes the appearance of the page to differ from the criteria established in the Vocabulary design system.

Description

Modify the code related to the logo in the header of the legaldb project so that it complies with the design established in Vocabulary.

This issue may be replicated in open source site if accepted, since it has a similar implementation of its logo.

Alternatives

Additional context

legaldb relevant code

<header class="container">
  <nav class="navbar">
    <div class="navbar-brand">
      <a class="has-text-black" href="/">
        <img src="/static/logo.d6336c44eac1.svg" alt="CC legal database logo">
      </a>
...
    </div>
...
  </nav>
</header>

Vocabulary index-logo.html example relevant code

<header>
    <div class="masthead">
        <h1><a class="identity-logo" href="#">Creative Commons</a></h1>
...

    </div>

...

</header>

How it currently looks

image

How does Vocabulary example looks

image

Even the difference is not that evident, the fact of having some sites using an svg image instead of text and using different html tags and classes as those indicated in Vocabulary is inconsistent with the design system.

Implementation

TimidRobot commented 2 weeks ago

https://github.com/creativecommons/legaldb/labels/%F0%9F%9A%A7%20status%3A%20blocked by: