creativecommons / legaldb

CC Legal Database: curated repository of Case Law and Scholarship data from around the world in a Django based website.
https://LegalDB.CreativeCommons.org/
MIT License
46 stars 69 forks source link

Feature : Align Footer with the Vocabulary Design System. #255

Closed SumaiyaaRq closed 2 weeks ago

SumaiyaaRq commented 3 weeks ago

Fixes

Description

This PR resolves the issue by adding the code for Global Footer from the Vocabulary Design System and making necessary changes in the required files.

Technical details

  1. I have modified the vocabulary.css ,file so that specific styles are defined for footer region , such that it is not overridden by any style which is written locally for a project.

  2. Also , thelibrary-vars.css had a class named .icon which caused problem with the icons used in body section of the page , (refer the image below ) , commenting it out solved the problem , with a thought that it would be better if we are more specific with styling icons and not declare styles for a class as a whole for it might cause inconsistencies.

  3. Additionally , I have also checked with vocabulary webpages if the changes in vocabulary.css cause an effect on footer area , there were no visible changes .

Screenshot 2024-10-28 at 9 06 14 PM

Tests

1.Open the CC Legal Database homepage. 2.Check the footer region for changes.

Screenshots

Screenshot 2024-10-30 at 11 10 49 PM Screenshot 2024-10-28 at 9 52 43 PM

Checklist

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin ``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```
SumaiyaaRq commented 3 weeks ago

@TimidRobot , Thank you for your feedback! I have made the requested changes and resolved conflicts , please review the PR when you have a moment.

TimidRobot commented 2 weeks ago

https://github.com/creativecommons/legaldb/labels/%E2%9B%94%EF%B8%8F%20status%3A%20discarded in favor of earlier pull request: