Fixed contribute card display issues for Scholarship section

Queen-codes commented 3 weeks ago

Fixes

Fixes #257 by @egbadon-victor

Description

This PR fixes the issue of the .contribute-card in the scholarship page not showing on smaller screen devices.

Technical details

To fix this issue, I removed the .is-hidden-touch class applied to the scholarship page's contribute card (<article class="card entry-post link no-border is-hidden-touch">). This class hides elements on smaller screen sizes. Then to fix the layout issues, I wrapped the contribute-card inside a case-holder div that contains both the card and the paragraph, similar to the cases section.

Screenshots

Before

After

Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main or master).
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin

``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```

Queen-codes commented 3 weeks ago

Please synchronize with the main branch and resolve conflicts

done, thank you very much

Queen-codes commented 2 weeks ago

Almost there--this needs to replace instead of add. It results in two cards on wider displays:

thank you! it was an oversight on my end.

TimidRobot commented 1 week ago

Deployed to Production

Per guides/deploy_to_heroku.md:

git push heroku main; date -u

Enumerating objects: 133, done.
Counting objects: 100% (123/123), done.
Delta compression using up to 10 threads
Compressing objects: 100% (56/56), done.
Writing objects: 100% (101/101), 28.47 KiB | 28.47 MiB/s, done.
Total 101 (delta 53), reused 90 (delta 42), pack-reused 0 (from 0)
remote: Resolving deltas: 100% (53/53), completed with 13 local objects.
remote: Updated 153 paths from 67d1626
remote: Compressing source files... done.
remote: Building source:
remote: 
remote: -----> Building on the Heroku-24 stack
remote: -----> Using buildpack: heroku/python
remote: -----> Python app detected
remote: -----> Using Python 3.12 specified in Pipfile.lock
remote: -----> Restoring cache
remote: -----> Using cached install of Python 3.12.7
remote: -----> Installing pip 24.0, setuptools 70.3.0 and wheel 0.44.0
remote: -----> Installing Pipenv 2024.0.1
remote: -----> Installing SQLite3
remote: -----> Installing dependencies using 'pipenv install --deploy'
remote:        Installing dependencies from Pipfile.lock (9debb0)...
remote: -----> $ python manage.py collectstatic --noinput
remote:        480 static files copied to '/tmp/build_3440bcfc/staticfiles', 884 post-processed.
remote: 
remote: -----> Discovering process types
remote:        Procfile declares types -> release, web
remote: 
remote: -----> Compressing...
remote:        Done: 75M
remote: -----> Launching...
remote:  !     Release command declared: this new release will not be available until the command succeeds.
remote:        Released v72
remote:        https://fast-eyrie-10628.herokuapp.com/ deployed to Heroku
remote: 
remote: Verifying deploy... done.
remote: Running release command...
remote: 
remote: Operations to perform:
remote:   Apply all migrations: admin, auth, contenttypes, legal_db, sessions, taggit
remote: Running migrations:
remote:   No migrations to apply.
To https://git.heroku.com/fast-eyrie-10628.git
   af4e2b8..5b828eb  main -> main
Thu Nov 14 16:04:36 UTC 2024

creativecommons / legaldb