[Fix] Contribute card disappearing on scholarship page

egbadon-victor commented 3 weeks ago

Fixes

Fixes #257 by @egbadon-victor

Description

This PR makes the contribute card component on the scholarship page display and responsive across all screen sizes.

Technical details

Includes the .cases-holder to wrap the contribute card
removes the .is-hidden-touch class, that causes the card to disappear on screen sizes lesser than 1024px

Tests

I ran the development server locally
Opened my browser developer tools, and adjust the screen size down all the way to 320px to ensure responsiveness

Screenshots

Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main or master).
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin

``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```

egbadon-victor commented 3 weeks ago

@TimidRobot I have synchronized with the main branch, and resolved all conflicts

TimidRobot commented 1 week ago

@egbadon-victor thank you for this work!

https://github.com/creativecommons/legaldb/labels/%E2%9B%94%EF%B8%8F%20status%3A%20discarded in favor of earlier pull request (PR):

258

egbadon-victor commented 1 week ago

Thanks @TimidRobot . Glad to have worked on it!

creativecommons / legaldb