search

creativecommons / og-image-generator

An open graph image generator for Creative Commons projects.
https://cc-og-image.vercel.app
MIT License
34 stars 14 forks source link

fix: dark mode #3

Closed rajat2502 closed 4 years ago

rajat2502 commented 4 years ago

Fixes

Fixes #2 by @zackkrida

Description

Fixes dark mode

Technical details

Change the svg colors when the theme is set to dark mode

Screenshots

Checklist

- [x] My pull request has a descriptive title (not a vague title like `Update index.md`). - [x] My pull request targets the *default* branch of the repository (`main` or `master`). - [x] My commit messages follow [best practices][best_practices]. - [x] My code follows the established code style of the repository. - [ ] I added tests for the changes I made (if applicable). - [ ] I added or updated documentation (if applicable). - [ ] I tried running the project locally and verified that there are no visible errors. [best_practices]:https://gist.github.com/robertpainsi/b632364184e70900af4ab688decf6f53 ## Developer Certificate of Origin
Developer Certificate of Origin ``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```
rajat2502 commented 4 years ago

Hey @zackkrida, can you please guide me about where I am doing wrong. This PR is still in progress.

zackkrida commented 4 years ago

Hi @rajat2502, you had a small typo in the css class and one incorrect value in the filter that caused your changes to not work. I fixed and merged though! Excellent work and research; I didn't think this feature was going to be possible using filter but you figured it out 😸

rajat2502 commented 4 years ago

Hey @zackkrida, thanks for helping me out!!! It's great to know that I was able to help. I am surely looking forward to contributing more to the organization. I would love to suggest more features and fix more bugs.

rajat2502 commented 4 years ago

I was thinking if we should add a download option there as well. Let me know if it's required or will be of some help then I will be happy to work on it as well.

rajat2502 commented 4 years ago

Another thing that came into my mind while working on this issue is that there should be an option to change the height & width of the images (just like the font size). Otherwise, some images might overflow from the image-wrapper.

zackkrida commented 4 years ago

@rajat2502 Please, make issues for any of your ideas! I already did for one of them: https://github.com/creativecommons/og-image-generator/issues/4