creativecommons / quantifying

quantify the size and diversity of the commons--the collection of works that are openly licensed or in the public domain
MIT License
22 stars 30 forks source link

[Feature] pipenv guide for windows #46

Closed satyampsoni closed 9 months ago

satyampsoni commented 1 year ago

Problem

There is no documentation to install pipenv for windows user in the Development Section of Readme.md. image

Description

This will help the windows users to install pipenv right from the documentation making it easier and less time consuming.

Implementation

satyampsoni commented 1 year ago

Apologies! As I am the beginner to opensource The changes were not merged properly.

satyampsoni commented 1 year ago

@TimidRobot A response from you will be highly appreciated.

Pursottam6003 commented 1 year ago

Hii @TimidRobot if its possible to still work on this issue please assign me the task

satyampsoni commented 1 year ago

This issue has already pull request. Pls work on another issue.

TimidRobot commented 1 year ago

Fix may be as simple as saying "Linux or Windows:" instead of "Linux:" with the same link.

satyampsoni commented 1 year ago

Okay! I'll add it as instructed.

TimidRobot commented 1 year ago

Okay! I'll add it as instructed.

I don't use Windows, which is why I said "may". If you use Windows, please exercise whatever solution you propose

satyampsoni commented 1 year ago

According to the documentation of pipenv homebrew installation is discouraged (NOTE in the screenshot) because pip installation works way smoother than homebrew. should I remove installation homebrew installation from the Readme.md and add pipenv installation for all three windows, linux and MacOS and for reference I'll add the pip official documentation link.? image

pushkar707 commented 1 year ago

hey @satyampsoni, I want to resolve this issue, I am a windows user myself, and I know how to install pipenv to windows. I can add the instructions to the documentation to help other windows users.

satyampsoni commented 1 year ago

I have changes done. I am just waiting for @TimidRobot reply then I'll commit the changes

TimidRobot commented 1 year ago

According to the documentation of pipenv homebrew installation is discouraged (NOTE in the screenshot) because pip installation works way smoother than homebrew. should I remove installation homebrew installation from the Readme.md and add pipenv installation for all three windows, linux and MacOS and for reference I'll add the pip official documentation link.? image

Please leave Homebrew installation in as it is used by CC Staff.

satyampsoni commented 1 year ago

Okay Noted