creativecommons / quantifying

quantify the size and diversity of the commons--the collection of works that are openly licensed or in the public domain
MIT License
24 stars 34 forks source link

[WIP] Refactor scripts #90, Adds logging #85 and cleans code and comments #86 by putting it in a shared library #95

Closed IamMQaisar closed 8 months ago

IamMQaisar commented 8 months ago

Fixes

Fixes #91 by @TimidRobot, #85 by @naishasinha and #86 by @IamMQaisar

Description

The shared code including Logging from various scripts has been moved to a shared library named quantify.py.

Technical details

To Handle PYTHONPATH, sys.path.append has been used. logger is used in a shared module that logs Date ,time , module_name from where error generated and error msg.

Checklist

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin ``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```
IamMQaisar commented 8 months ago

Closed other Pulls and doing all issues #89 , #85 , and #91 solutions in this single pull #95 .This will show you only the latest changes, with organized code, added logger, and shared module, to help you not get cluttered in the codebase with multiple changes. @TimidRobot

IamMQaisar commented 8 months ago

Due to some Auto_renaming issue I'm facing on the branch by GITHUB, reposting this pull