[Feature] Add 'The Greats' as an external source

[PreciousOritsedere]

Problem

The goal is to add a good number of external sources to give users a variety of results from different sources.

Description

The Greats is a free site to discover awesome themed art illustrations. it is also licensed under Creative Commons Attribution-NonCommercial 4.0 International..Gotten from the additional sources list of Openverse available in the file get-additional-sources.ts mentioned in https://github.com/creativecommons/search/issues/48

Adding The Greatss as an external source to CC search will be a good addition and will benefit our users by giving them more search options.

Alternatives

Additional context

Implementation

• [x] I would be interested in implementing this feature.

[PreciousOritsedere]

@possumbilities If this issue is triaged, please assign to me, I would love to work on it please :)

[possumbilities]

Please verify and affirm that adding this engine is inline with our new listed criteria here in the Engines Guide, before we proceed with making this status: ready for work

[PreciousOritsedere]

Please verify and affirm that adding this engine is inline with our new listed criteria here in the Engines Guide, before we proceed with making this status: ready for work

I have read through the criteria listed in the Engines Guide and I affirm that The Greats is inline with the listed criteria.

[ImaJin14]

Please verify and affirm that adding this engine is inline with our new listed criteria here in the Engines Guide, before we proceed with making this status: ready for work

I have read through the criteria listed in the Engines Guide and I affirm that The Greats is inline with the listed criteria.

It does fall in line with CC license but doesn't seem to return much valuable data...

I've tried a few common searches and the return was few... i.e either a one or two search return

But according to the criteria it should return a vast variety such as 10 results and above.... That is if I'm not wrong

[PreciousOritsedere]

Please verify and affirm that adding this engine is inline with our new listed criteria here in the Engines Guide, before we proceed with making this status: ready for work

I have read through the criteria listed in the Engines Guide and I affirm that The Greats is inline with the listed criteria.

It does fall in line with CC license but doesn't seem to return much valuable data...

I've tried a few common searches and the return was few... i.e either a one or two search return

But according to the criteria it should return a vast variety such as 10 results and above.... That is if I'm not wrong

I believe you’re very wrong. When you search for something on the site, it returns more than 10 results and even has the option for several themes. Maybe you can go back to the site and try searching again.

[ImaJin14]

Please verify and affirm that adding this engine is inline with our new listed criteria here in the Engines Guide, before we proceed with making this status: ready for work

I have read through the criteria listed in the Engines Guide and I affirm that The Greats is inline with the listed criteria.

It does fall in line with CC license but doesn't seem to return much valuable data...

I've tried a few common searches and the return was few... i.e either a one or two search return

But according to the criteria it should return a vast variety such as 10 results and above.... That is if I'm not wrong

I believe you’re very wrong. When you search for something on the site, it returns more than 10 results and even has the option for several themes. Maybe you can go back to the site and try searching again.

Here's just a simple search of Common art theme and the return is zero

[PreciousOritsedere]

Please verify and affirm that adding this engine is inline with our new listed criteria here in the Engines Guide, before we proceed with making this status: ready for work

I have read through the criteria listed in the Engines Guide and I affirm that The Greats is inline with the listed criteria.

It does fall in line with CC license but doesn't seem to return much valuable data... I've tried a few common searches and the return was few... i.e either a one or two search return But according to the criteria it should return a vast variety such as 10 results and above.... That is if I'm not wrong

I believe you’re very wrong. When you search for something on the site, it returns more than 10 results and even has the option for several themes. Maybe you can go back to the site and try searching again.

Here's just a simple search of Common art theme and the return is zero

The Greats is a site for artworks. I believe if you type in “art” you’ll get varieties of results. It’s not a site for finding animals hence why I think tiger won’t bring forth any results

[ImaJin14]

@PreciousOritsedere so you do understand that, that engine we'll work for only the word search of art

Which means this engine already has default themes which users can browse through but won't be able to do specific searches

[PreciousOritsedere]

@PreciousOritsedere so you do understand that, that engine we'll work for only the word search of art

Which means this engine already has default themes which users can browse through but won't be able to do specific searches

Since “The Greats” is an a site for artworks, it makes sense that the users will be there to search for art illustrations. I noted on the issue description that it is a site for art. “Tiger” on the other hand doesn’t fall under a theme, in my opinion though.

[ImaJin14]

@PreciousOritsedere so you do understand that, that engine we'll work for only the word search of art

Which means this engine already has default themes which users can browse through but won't be able to do specific searches

Since “The Greats” is an a site for artworks, it makes sense that the users will be there to search for art illustrations. I noted on the issue description that it is a site for art. “Tiger” on the other hand doesn’t fall under a theme, in my opinion though.

Here's an example of another site using the search query tiger

What I'm saying is users coming to the search portal will search using queries and the greats doesn't offer that luxury.... Well there's already a PR for this issue so it is fine....

[PreciousOritsedere]

@PreciousOritsedere so you do understand that, that engine we'll work for only the word search of art Which means this engine already has default themes which users can browse through but won't be able to do specific searches

Since “The Greats” is an a site for artworks, it makes sense that the users will be there to search for art illustrations. I noted on the issue description that it is a site for art. “Tiger” on the other hand doesn’t fall under a theme, in my opinion though.

Here's an example of another site using the search query tiger

What I'm saying is users coming to the search portal will search using queries and the greats doesn't offer that luxury.... Well there's already a PR for this issue so it is fine....

This screenshot doesn’t return artworks tho. This is more like phone themes. Anyways I’m sure the mentor will decide if it should be added or not. Thanks for your kind observations.

[possumbilities]

@PreciousOritsedere what you've done in the PR #151 here works, but there's an obstacle I've noticed. The Greats doesn't allow any of the images to be used for commercial purposes, but that's a checkbox on the CC Search Portal. Any ideas on how to address this?

[possumbilities]

Secondarily, in reference to #160 to fully resolve this Issue the appropriate aria-label will need to be added to the engine button.

[PreciousOritsedere]

@PreciousOritsedere what you've done in the PR #151 here works, but there's an obstacle I've noticed. The Greats doesn't allow any of the images to be used for commercial purposes, but that's a checkbox on the CC Search Portal. Any ideas on how to address this?

I just noticed this as well. Are we allowed to add an additional text that says:(not for commercial use) or does all the search engines have to be for commercial use, compulsorily

[PreciousOritsedere]

Secondarily, in reference to #160 to fully resolve this Issue the appropriate aria-label will need to be added to the engine button.

Okay noted. I’ll do that. Do I go ahead now? Or I should hold on till we resolve the non commercial use issue

[possumbilities]

@PreciousOritsedere I think you could go ahead and correct the aria-label. As for the rest, I'm unsure what to do about it considering that with the current site UX there's not a realistic option to course correct. We may have to unfortunately move this to blocked if we can't find a sound alternative within the current site UX.

[PreciousOritsedere]

@PreciousOritsedere I think you could go ahead and correct the aria-label. As for the rest, I'm unsure what to do about it considering that with the current site UX there's not a realistic option to course correct. We may have to unfortunately move this to blocked if we can't find a sound alternative within the current site UX.

Okay. Duly noted