creativecommons / search

Creative Commons Search Portal
https://search.creativecommons.org/
MIT License
18 stars 94 forks source link

[bug] Reconsider inclusion/function of Jamendo, terms and filtering are misaligned #216

Open possumbilities opened 1 year ago

possumbilities commented 1 year ago

Description

Originally posted by @heyakyra in https://github.com/creativecommons/search/issues/124#issuecomment-1684080259

Also, the search returns the "invalid search result: https://www.jamendo.com/search?q=fq" because of the malformed search query.

The malformed query may be due to the fact that the Jamendo site may have been updated and their search query format updated as well, implying that we may need to update ours in return so as to get expected results.

The current state is broken still, and results in queries like so, where the search terms become [query-nc] [-nd] instead of [query] [-nc] [-nd]:

Screenshot 2023-08-18 at 10-15-33 CC Search Portal Screenshot from 2023-08-18 10-14-54

And either way, the filters for removing noncommercial and non-derivative licensed results don't work.

So as it stands, the old Jamendo contains music that can be modified, downloaded, and reused (Personal use).

And the site licensing.jamendo contains music that can be used for commercial purposes and played in public places.

[…] So for example, if the user checked the "use for commercial purposes" checkbox, we redirect to licensing.jamendo else we redirect to old Jamendo

This is incorrect, and therefore the solution implemented in #137 is backwards. Jamendo has adopted the language of the music industry oligopoly: "can be used commercially" actually means you can't use it commercially until you buy a license. "can be used personally" means you can use it personally (and maybe commercially too, but it's not in our financial interest to inform you)

Resolution

heyakyra commented 1 year ago

Thank you! The only way to filter by license is using their API which users can do through Openverse instead of the official website: https://github.com/WordPress/openverse/issues/1319#issuecomment-1684183872