Closed Dev-JoyA closed 1 month ago
@Dev-JoyA I think some of your formatting didn't come through, it seems like you are referencing tags that aren't in the description of the Issue?
@Dev-JoyA I think some of your formatting didn't come through, it seems like you are referencing tags that aren't in the description of
@Dev-JoyA I think some of your formatting didn't come through, it seems like you are referencing tags that aren't in the description of the Issue?
I will edit it and notify you, I will also do well to add screenshots for clarity
@possumbilities there is no sidebar region in serach portal so the aside tag is unnecessary, i have edited the description, and this is the only issue left
@Dev-JoyA Thank you, I think is ready for work now.
After reviewing #287 and investigating further I believe this Issue was approved in error.
I think there might be a misunderstanding about the nature of this sturcture. There are two header
elements present on most pages utilizing Vocabulary.
There is the Header - Global Area, and there is the Page Header - Region itself. Each of these relies on placement within a different context.
I'm closing this Issue and the related PR as the structure does in fact seem to reflect the correct implementation at this time.
@possumbilities I totally agree , that was before you explained the concept of the two header to me .
Description
The search portal has an inconsistent HTML structure which affects accessibility and content organization.
Reproduction
Expectation
The expected HTML structure should be body > main > header
Environment
Device: Laptop OS: Windows 10 Browser: Chrome
Additional context
The implementation of the Vocabulary design system across the Creative Commons web entities has been inconsistent, leading to these structural issues. Addressing them is crucial for ensuring compliance with design standards and enhancing accessibility
Resolution