Closed Dev-JoyA closed 1 month ago
Name | Link |
---|---|
Latest commit | a84a16b6a222a7135cf04397c6c9dd9aa2503a57 |
Latest deploy log | https://app.netlify.com/sites/cc-search-portal/deploys/66ffb7e1f34a340008ebc2eb |
Deploy Preview | https://deploy-preview-242--cc-search-portal.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
See comment on
After reviewing #287 and investigating further I believe this Issue was approved in error.
I think there might be a misunderstanding about the nature of this sturcture. There are two
header
elements present on most pages utilizing Vocabulary.There is the Header - Global Area, and there is the Page Header - Region itself. Each of these relies on placement within a different context.
I'm closing this Issue and the related PR as the structure does in fact seem to reflect the correct implementation at this time.
Closing
…y>main>header
Fixes
Description
The initial structure was incorrect and did not follow the layout guidelines outlined in the Vocabulary documentation. As a result, the search portal has an inconsistent HTML structure, impacting both accessibility and content organization.
Technical details
Tests
I ran the code in my browser using Live Server in VSCode to test the UI changes. This allowed me to visually confirm that the updates to the structure and styling were correctly applied.
Screenshots
before correction After correction After correcting the display in css
Checklist
Update index.md
).main
ormaster
).Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin
``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```