creativecommons / search

Creative Commons Search Portal
https://search.creativecommons.org/
MIT License
19 stars 114 forks source link

add hover effect to each of the button #273

Closed adebisi4145 closed 1 month ago

adebisi4145 commented 1 month ago

Fixes

Description

This pull request adds hover effect to each of the buttons which enhances user experience

Technical details

Tests

Screenshots

Before1

Before2

After1

After2

After3

After4

Checklist

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin ``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```
netlify[bot] commented 1 month ago

Deploy Preview for cc-search-portal ready!

Name Link
Latest commit 91ed653e490ee223a46b77c7ad392457f2ec20f6
Latest deploy log https://app.netlify.com/sites/cc-search-portal/deploys/67045df394e0f10008a300a2
Deploy Preview https://deploy-preview-273--cc-search-portal.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

adebisi4145 commented 1 month ago

Hello @TimidRobot , @Shafiya-Heena, I would love your review on this PR. Thank you for your time

possumbilities commented 1 month ago

Hi, and thank you for doing this work. After further review the Issue in question here as moved to https://github.com/creativecommons/search/labels/%F0%9F%9A%A7%20status%3A%20blocked so I'm closing this PR for now.

Additionally, this PR contains changes to vocabulary.css directly which should be avoided. Localized changes should be bound outside of Vocabulary (such as within the style.css file)

SisiVero commented 1 month ago

Hi @adebisi4145 , great work you did here. @possumbilities , thank you for the last line. I usually make the mistake of making changes to the vocbulary.css.

Bisi, might I also add that for mobile screens, a hover effect is not needed as the user will not be hovering over the button but rather tapping on it. A hover effect is usually applied and greatly advised to be applied to desktop screens only.