creativecommons / search

Creative Commons Search Portal
https://search.creativecommons.org/
MIT License
19 stars 114 forks source link

Space Added Between Search Input And Button In Mobile Screens #307

Closed SisiVero closed 1 month ago

SisiVero commented 1 month ago

Fixes

Description

This pull request resolved the bug issue of clustering search input and button. The search button now has a margin top for mobile screens, creating a space between it and the input field.

Technical details

Essential care was taken to avoid the margin top being added to desktop screens too.

Tests

  1. Open the search interface on mobile or use the inspect tool to switch to mobile
  2. Check the input field and button
  3. see the change

Screenshots

Space added for mobile screens:

mobileView

Desktop screen still maintains the no space:

desktopView

Checklist

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin ``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```
netlify[bot] commented 1 month ago

Deploy Preview for cc-search-portal ready!

Name Link
Latest commit 8e27ba6fd4c234168ac666c1413587a5add5e2a3
Latest deploy log https://app.netlify.com/sites/cc-search-portal/deploys/6713e482fc200d000826740c
Deploy Preview https://deploy-preview-307--cc-search-portal.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.