[Feature] Reduce threshold for two-column grid on mobile devices

egbadon-victor commented 1 month ago

Fixes

Fixes #310 by @SylviaUzoh1

Description

This PR reduces the threshold for two-column grid on mobile devices from 680px to about 420px

Technical details

This implementation changes the grid-template-columns: repeat(auto-fit, minmax(250px, 1fr)); line to grid-template-columns: repeat(auto-fit, minmax(150px, 1fr)); `

Tests

Fork and clone the repo to your local machine
Run the server and open on your browser
Using chrome developer tools, reduce the screen width and observe the new width where two columns break in to a single column.
Observe that this change didn't cause any breaking changes

Screenshots

Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main or master).
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin

``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```

netlify[bot] commented 1 month ago

Deploy Preview for cc-search-portal ready!

Name	Link
Latest commit	4b70012b102bcd9c71e735903da1b6f43d008e88
Latest deploy log	https://app.netlify.com/sites/cc-search-portal/deploys/6718a6381a9cbd0008ae09de
Deploy Preview	https://deploy-preview-311--cc-search-portal.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

possumbilities commented 1 month ago

Fixed by

312

Closing, this PR resolves the Issue but also alters the behavior on larger screens as well.

egbadon-victor commented 1 month ago

@possumbilities this is noted. Thanks for the feedback

creativecommons / search