search

creativecommons / search

Creative Commons Search Portal
https://search.creativecommons.org/
MIT License
19 stars 114 forks source link

[Bug] Footer uses Twitter logo instead of Bluesky logo #315

Open SumaiyaaRq opened 6 days ago

SumaiyaaRq commented 6 days ago

Description

The footer currently displays the Twitter logo in the social-menu . According to the new design system, the social-menu should contain the Bluesky logo and not the Twitter logo in the footer region . This discrepancy may cause confusion and needs to be updated for consistency with the new design guidelines.

Reproduction

  1. Open the website .
  2. Navigate to the footer region .
  3. Observe the logos in the footer section.
  4. See error.

Expectation

The footer should display the Bluesky logo instead of the Twitter logo. Updating the footer to reflect this change will ensure alignment with the design guidelines and avoid user confusion.

Screenshots

Actual social-menu :

Screenshot 2024-11-20 at 11 56 24 PM

social-menu according to Vocabulary Design System :

Screenshot 2024-11-20 at 11 57 39 PM

Environment

Additional context

https://github.com/creativecommons/vocabulary/blob/3633bb1f6e982b42575309558e6aaa3ddf906d8b/docs/index.html#L354-L362

Resolution

SumaiyaaRq commented 3 days ago

Hi @possumbilities , I am currently working on this issue (#315) , and while implementing the solution, I realised that the necessary changes require modifications to some upstream files . I’ve made some progress, and the icon starts appearing after modifying the files style.css & index.html . However, to ensure the icon is displayed correctly and functions as intended, I need to add a path to the fa-icons.svg file located in the upstream Vocabulary folder.

In a previous contribution, I was advised not to modify files in the upstream folder. I want to confirm if this guideline still applies here or if an exception can be made in this case. Alternatively, if there’s a specific approach you’d like me to follow , I’d appreciate your guidance.

Thank you for your support!

possumbilities commented 1 day ago

@SumaiyaaRq The correct course here would be to add the most current versions of the library-vars.css and fa-icons.svg files from the upstream Vocabulary repository to this repository's Vocabulary.

for similar, see:

SumaiyaaRq commented 15 hours ago

@possumbilities Thank you for the guidance !