creativecommons / vocabulary-theme

WordPress Theme implementation of the Vocabulary design system
GNU General Public License v2.0
3 stars 6 forks source link

[Bug] hardcoded SVG ref in `style.css`, doesn't load already existing css variable in `library-vars.css` #59

Closed possumbilities closed 8 months ago

possumbilities commented 10 months ago

Description

The variable already exists for the cc-heart-filled reference in library-vars.css, which is imported at the top of style.css. Therefore:

Short-term solution

On line 714 of style.css

--icon-sprite: url('vocabulary/svg/cc/icons/cc-icons.svg#cc-heart-filled');

change to

--icon-sprite: var(--cc-heart-filled);

Medium-term solution

Long-term solution

Expectation

The behavior of style.css should use already present variables where possible.

Additional context

In older browsers, especially Webkit 12, there might be issues with loading files due to layers, relative css urls, and related.

Resolution