search

creativecommons / vocabulary

A cohesive system of design for Creative Commons
https://vocabulary-docs.netlify.app
Creative Commons Zero v1.0 Universal
8 stars 67 forks source link

Bug: Unclosed opening <nav> tag in person-page.html file #313

Closed SumaiyaaRq closed 2 weeks ago

SumaiyaaRq commented 2 weeks ago

Description

The opening <nav> tag is missing the closing angle bracket (>), which prevents proper rendering of the navigation section. https://github.com/creativecommons/vocabulary/blob/3b23d444c94b81f9d8d7c639031a797410f5718f/specimen/contexts/person-page.html#L226

Reproduction

  1. Open the person-page.html file using live server
  2. Navigate to footer region
  3. See error

Expectation

The<nav> tag should be properly closed. Since the tag is missing the closing >, it is causing improper rendering of the HTML code , leading to layout issues .

Screenshots

Screenshot 2024-11-08 at 10 34 04 PM

Environment

Resolution

SumaiyaaRq commented 2 weeks ago

Hi @rahulptl165 , Thank you for your PR! I really appreciate your effort on this. However, just to clarify, the issue hasn't yet been labeled as ready for work . As per the guidelines, we typically wait for that label before starting work on the issue to ensure it's ready for contributors. I would suggest you to go through the Contribution Guidelines to know how issues and PRs are managed here , it would definitely be helpful for your future contributions to the organization.

rahulptl165 commented 2 weeks ago

Hi, @SumaiyaaRq, Thanks for the feedback! I’ll review the Contribution Guidelines to align better with the process. Looking forward to contributing more effectively!