possumbilities
commented
3 months ago @TimidRobot The copyright bit needs to probably be clearer. But the versions of the icons actually change the visual styling of the icons, and several of the icons used within the design are tied to those visual stylings so upgrading them would create a lot of changes we'd have to re-account for that starts to get into redesign land.
We also use very few of them. Upgrading the 6.3.0 to 6.5.1 might be worth it or possible if we want any additional icons, but again if it changes the actual shape or implementation of the icon then we can't; The changes there are also likely to be mostly in the css and js bits which we don't use.
I'll look into it further because there might be room for improvement here, but there's likely going to always be a need to keep the versions mixed.
lalitkumawat1m
Problem
We use multiple version of the Font Awesome free icons. For example:
fa-angle-downis Font Awesome Free 5.11.0: https://github.com/creativecommons/index-prototype/blob/ebf1921a70f2d22046cf0a76af3e03859e473f32/src/vocabulary/svg/font-awesome/icons/fa-icons.svg#L15-L18fa-instagramis Font Awesome Free 6.3.0: https://github.com/creativecommons/index-prototype/blob/ebf1921a70f2d22046cf0a76af3e03859e473f32/src/vocabulary/svg/font-awesome/icons/fa-icons.svg#L63-L66Also, some of the icons don't include a copyright comment.
Description
use Font Awesome Free 6.5.1 (or current version at time of implementation) for all FA icons(see comment-2023160268, below)Additional context