creativecommons / wp-plugin-creativecommons

Official Creative Commons plugin for licensing your content. With Creative Commons licenses, keep your copyright AND share your creativity.
https://wordpress.org/plugins/creative-commons/
GNU General Public License v2.0
151 stars 105 forks source link

Suggestions #72

Open a8bit opened 5 years ago

a8bit commented 5 years ago

There are a couple of things that need to happen before I can activate this plugin.

I don't quite see how you are going to integrate blocks with this. If the idea is to display the licence in the footer or in a widget, it would probably be better as custom meta on the page/post/taxonomy. If you want the licence to be included in the body of the page/post you don't need a widget/footer for it.

TimidRobot commented 5 years ago

@ChoccyHobNob Thank you for taking the time to write this up!

a8bit commented 5 years ago

I am keen to see this plugin become something useful. I have a couple of websites that offer creations using differing licences and its a pain to manage at the moment, this plugin looks like it could solve those problems so I'd like to help push it in the right direction. A good plugin will encourage more usage of the licences as well, that wouldn't be a bad thing.

ahmadbilaldev commented 5 years ago

Thank you for the suggestions.

I totally agree with you on 2 and 3. and they are already under progress. The widget options are also a good idea, noted.

Could you elaborate more on the fourth point?

It is possible to integrate the features in blocks, maybe by using Rich Text blocks. We can add these features to both the blocks and the widget and let the user decide the one. The idea is to support Gutenberg.

If you want the license to be included in the body of the page/post you don't need a widget/footer for it.

This can certainly be considered, I am not a fan of how the footer looks. Right now, I am re-writing the settings, thank you for your time, I will definitely consider these suggestions.

a8bit commented 5 years ago

Maybe I misunderstand how the blocks will be implemented. If I have a site licence set, and then set a licence for my page, the page licence overrides the site licence. What happens if I then add a licence to the body text using a block? does it remove the sidebar widget or change it? can I have multiple items on a page with multiple licence blocks (the 'useful' use case I imagine for a block based licence) if I can, what happens to the licence displayed in the footer/widget?

a8bit commented 5 years ago

Point 4. I think I am thinking about custom post types, not taxonomies. Gallery plugins, download plugins, portfolio plugins etc can implement custom post types that go along with posts, pages, media etc. It should be possible to set the licence for these post types as well as posts and pages

ahmadbilaldev commented 5 years ago

Maybe I misunderstand how the blocks will be implemented. If I have a site licence set, and then set a licence for my page, the page licence overrides the site licence. What happens if I then add a licence to the body text using a block? does it remove the sidebar widget or change it? can I have multiple items on a page with multiple licence blocks (the 'useful' use case I imagine for a block based licence) if I can, what happens to the licence displayed in the footer/widget?

You're right. The use case is multiple attributions to different content. If we include a block, the widget will not be affected. That is why we are including the warning before the license text that goes:

Except otherwise noted, the content on this site is attributed by some license.

With the next release (will be out in a couple of days) I have removed the border of the blocks and made a few changes. If you have some input about the design of the blocks that will be welcome as well.

a8bit commented 5 years ago

OK I'll check it out.

ahmadbilaldev commented 5 years ago

New version v2019.7.2 released. See the changelog for more.

ahmadbilaldev commented 5 years ago

74: Options added to the widget.

ahmadbilaldev commented 5 years ago

Updated with completed suggestions.

a8bit commented 5 years ago

Sorry it's taken me a few days to get back to this. Everything is much improved, there are still a few issues.

I changed this code in creativecommons-widget.php

        public function widget( $args, $instance ) {
            $title = apply_filters( 'widget_title', $instance['title'] );
            echo $args['before_widget'];
            echo $args['before_title'] . $title . $args['after_title'];
            $this->print_license_widget( );
            echo $args['after_widget'];
        }

to this

        public function widget( $args, $instance ) {
            if ( ! empty($instance['title']) ) {
                $title = apply_filters( 'widget_title', $instance['title'] );
                echo $args['before_widget'];
                echo $args['before_title'] . $title . $args['after_title'];
            } else {
                echo $args['before_widget'];
                $args['after_title'];
            }
            $this->print_license_widget( );
            echo $args['after_widget'];
        }

Now I get this Screenshot 2019-08-27 at 17 56 22 Which is more what I had in mind.

a8bit commented 5 years ago

A couple more.

Blocks don't have any formatting options other than fore/background colour. being able to change the alignment and font size would be good.

I'd like to be able to change the widget text for each page. Ideally I'd like a footer with a sitewide licence, each page to be able to have an overriding page licence and then the content have overriding block level licences.

I can't turn the CC off for other non-cc licences, I have some fonts that are SIL licensed. This gets us into the realms of being able to pick all the other open source licences, maybe not somewhere you want to go.

Overall this is looking great now! well done :)

one909 commented 4 years ago

😭