search

creativecommons / wp-theme-cc-chapter

Creative Commons Chapter site theme (including chapter sites setup, taxonomies, and widget code)
GNU General Public License v2.0
1 stars 9 forks source link

Search on chapter sites do not work yet – no search page implemented #16

Closed mzeinstra closed 5 years ago

mzeinstra commented 5 years ago

The new archive page allows users to search through the posts, however there is no search page available yet.

See: https://nl-beta.creativecommons.org/?search=Open+Access

hugosolar commented 5 years ago

The wordpress default search works with the s parameter the search you refer should be like this https://nl-beta.creativecommons.org/?s=Open+Access I use the search parameter only in the post archive to avoid conflicts with the default wordpress search does that make sense to you?

mzeinstra commented 5 years ago

Makes sense to me.

When I usesd the ?search query I did not find anything. Now I do.

However this is not implemented throughout.

Compare: https://nl-beta.creativecommons.org/news-temp/ (page template) with https://nl-beta.creativecommons.org/nieuws/ build in 'post page'

the latter has no search, the former has.

Maybe I am misusing the issue now :)

hugosolar commented 5 years ago

haha don't worry. I added the filter to the 'post page' in 72dffa4