search

creativedotdesign / tofino

WordPress boilerplate theme on a modern stack. NPM and Composer.
Other
29 stars 6 forks source link

Use Husky to run Pre-commit hook for gulp build #245

Closed danimalweb closed 5 years ago

danimalweb commented 7 years ago

Always run the build before we commit, or push.

danimalweb commented 7 years ago

This is in progress. You will not be able to commit to the repo unless the code passes the linter checks for PHP, JS and SCSS.

cc @mrchimp

danimalweb commented 7 years ago

When closing this, remember to update the build process on BitBucket. Half of the vendor directory should no longer be deployed as many of the tools were for linting. Of linting is 100% ok before committing we don't need to do it on deployment. Faster deployments too. Fix up the composer.json file.

danimalweb commented 6 years ago

The pre-commit hook for linting should only run against the staged files.

danimalweb commented 5 years ago

Closing no longer relevant.