Stop emitter leaving particles behind

creativelifeform / three-nebula

WebGL based particle system engine for three.js

https://three-nebula.org/

MIT License

945 stars 76 forks source link

Stop emitter leaving particles behind #169

Open rohan-deshpande opened 3 years ago

rohan-deshpande commented 3 years ago

As referenced here https://github.com/creativelifeform/three-nebula/discussions/147 stopEmit is stopping particles from living out their natural life span.

Need to play with the isEmitting prop on the emitter. Best course of action would be to set up an experiment in the sandbox to test this out and make sure no existing functionality is broken

ertugrulcetin commented 2 years ago

Hi @rohan-deshpande any updates on this?

andrewleek-droplab commented 2 years ago

I have just made a pull-request to resolve this bug. You can find it here: https://github.com/creativelifeform/three-nebula/pull/206

ertugrulcetin commented 2 years ago

This looks nice, thanks! @andrewleek-droplab - @rohan-deshpande can you merge it please?