Viewable function fixed for display:none elements

creativelive / appear

execute callbacks when dom elements appear in and out of view

http://creativelive.github.io/appear/

MIT License

177 stars 43 forks source link

Closed kashifeqbal closed 6 years ago

kashifeqbal commented 6 years ago

Added OffsetWidth and OffsetHeight check for display:none elements Added aria-hidden attributes check also

JustinBeaudry commented 6 years ago

If there's an issue that this is supposed to be resolving, can you create that first for some context around why these changes are necessary?

JustinBeaudry commented 6 years ago

I'm going to close this PR because there's no associated Issue listed that this fixes. I will reopen and review when an Issue is created. e.g. Bug