search

creativelive / appear

execute callbacks when dom elements appear in and out of view
http://creativelive.github.io/appear/
MIT License
178 stars 43 forks source link

Add the third parameter to all addEventListener and removeEventListener ... #3

Closed dzoba closed 9 years ago

dzoba commented 9 years ago

addEventListener requires 3 arguments otherwise older browsers throw exceptions.

MDN claims its optional, but required for "broad compatibility": https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener

Heres an example of issues happening on iPhone: http://www.sencha.com/forum/showthread.php?139339-quot-Not-enough-arguments-quot-error-caused-by-Ext.History

Other places around the web: teddyzeenny/rsvp.js@1c88363

We think we're seeing these errors in CreativeLive's New Relic Browser Dashboard.

ryanjadhav commented 9 years ago

looks good to me