Closed jkellerer closed 6 months ago
Attention: Patch coverage is 90.38902%
with 42 lines
in your changes are missing coverage. Please review.
Project coverage is 70.50%. Comparing base (
5fad1cb
) to head (9a46c4c
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@creativeprojects , think it is ready now. had it running on one of my machines and schedules work like before (had them recreated to use run-schedule).
I looked at the MR and so far it all looks good to me. I'm going to play with it on some of my configs and see how it goes 👍🏻
Oh BTW I forgot to mention I think we have no way of displaying a group configuration: the <profile>.show
command only works with profiles 🤔 we could add the feature later though
Thanks for checking!
Had already began refactoring #290 to allow scheduling groups. That is the only remaining part.
Draft for schedule structs discussed in #80
.. and finally group support (in this PR, it is config only. Also needs updates to scheduling (partially done in #290), coming later):