Closed jkellerer closed 4 months ago
@creativeprojects , do you have any concerns with this. It does change previous behaviour in that it now sends command output by default (though #343 allows to control it).
On the other hand the previous version was a bit inconsistent since we sent it to log files but not to syslog.
Yeah I'm fine with it 👍🏻 Thanks for the PR 😉
Attention: Patch coverage is 84.61538%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 70.91%. Comparing base (
2a7d5fc
) to head (8c12867
).
Files | Patch % | Lines |
---|---|---|
wrapper.go | 0.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Marked it ready for a final review, manually tested all options.
In relation to #343, this PR adds local syslog server and command output redirection into syslog.
Motivation: Currently I redirect systemd output to syslog (including all stdout/err from resticprofile). This PR allows to have the same support using the built-in syslog client, which has the advantage of more consistent timestamps (not duplicated in stdout formatted log).
The following additional log URLs are added:
syslog:
(local syslog server via unix socket)syslog://hostname
(udp on default port 514)syslog://hostname:514
(udp on port 514)syslog-tcp://hostname
(tcp on default port 514)syslog-tcp://hostname:514
(tcp on port 514)