search

creativeprojects / resticprofile

Configuration profiles manager and scheduler for restic backup
https://creativeprojects.github.io/resticprofile/
GNU General Public License v3.0
604 stars 29 forks source link

`profile.backup.exclude-caches` is ignored in profile #356

Closed Silvea12 closed 3 months ago

Silvea12 commented 3 months ago

The flag exclude-caches is not applied to the backup arguments, either by manual run or in the schedule, thus backing up cache directories even if exclude-caches = true is set in the backup section.

It's been a hot minute since I've messed with a golang codebase, but it looks like SetOtherFlag() is never being called for passthrough flags, nor is there an explicit ExcludeCaches property in the backup section in profile.go

Worth noting: it looks like a good number of other documented flags are also not being passed through.

Silvea12 commented 3 months ago

Wait, I misunderstood the --exclude-caches flag - it keeps the CACHEDIR.TAG file! All seems to be working. Closing this.