search

creativescala / doodle

Compositional vector graphics in Scala / Scala.JS
https://creativescala.org/doodle/
Apache License 2.0
327 stars 75 forks source link

doodle_2.13 artifact is empty #105

Closed Iltotore closed 2 years ago

Iltotore commented 2 years ago

Hello, the artifact org.creativescala::doodle:0.9.25 is empty (only contains the manifest file). Is this intented ?

Here is the Maven Search Page

noelwelsh commented 2 years ago

Thanks for letting me know. No idea why that would happen.

SethTisue commented 2 years ago

I think this might be normal? Because the .pom pulls in the JARs containing the actual code as dependencies?

Iltotore commented 2 years ago

I think this might be normal? Because the .pom pulls in the JARs containing the actual code as dependencies?

The pom of this artifact only contains the scala library. This might be the cause of this issue.

SethTisue commented 2 years ago

indeed, that's what I see at https://repo1.maven.org/maven2/org/creativescala/doodle_2.13/0.9.25/doodle_2.13-0.9.25.pom

and it's a regression since 0.9.23; https://repo1.maven.org/maven2/org/creativescala/doodle_2.13/0.9.23/doodle_2.13-0.9.23.pom has the dependencies

@noelwelsh I looked at the diffs since then but the problem wasn't obvious to me. is it obvious to you? (if not, maybe we need to bisect to see which commit caused the problem?)

noelwelsh commented 2 years ago

@noelwelsh I looked at the diffs since then but the problem wasn't obvious to me. is it obvious to you? (if not, maybe we need to bisect to see which commit caused the problem?)

I know approximately nothing about how publishing / POMs / Maven works, so it's safe to assume I don't have a clue what has caused the problem.

Iltotore commented 2 years ago

@noelwelsh I looked at the diffs since then but the problem wasn't obvious to me. is it obvious to you? (if not, maybe we need to bisect to see which commit caused the problem?)

I know approximately nothing about how publishing / POMs / Maven works, so it's safe to assume I don't have a clue what has caused the problem.

I don't use SBT but isnt this line the cause of this issue ?

I also assume these comments should be removed.

noelwelsh commented 2 years ago

Thanks, I'll take a look when I get time.

SethTisue commented 2 years ago

I don't think pomIncludeRepository is relevant here.

I've submitted what I thiiiiink is a fix at #108

noelwelsh commented 2 years ago

I've published a 0.10.0 snapshot and it looks like the POM contains the dependencies as expected. E.g. https://oss.sonatype.org/service/local/repositories/releases/content/org/creativescala/doodle_2.13/0.10.0/doodle_2.13-0.10.0.pom

At the time of writing it hasn't been synced to Maven.

Let me know if this doesn't for you and I'll ... well, I'm not sure what I'll do.

noelwelsh commented 2 years ago

Looks like everything is correct. Please reopen if you run into an issue.