creativescala / doodle

Compositional vector graphics in Scala / Scala.JS
https://creativescala.org/doodle/
Apache License 2.0
327 stars 75 forks source link

update to sbt-typelevel 0.6 with Laika 1.0 #138

Closed jenshalm closed 11 months ago

jenshalm commented 11 months ago

Hello out there. I picked doodle as a sample project for a test migration to Laika 1.0 as you do a few things other projects don't (writing your own directives, not using the Helium theme) which makes it a good additional test case. I'm turning this into a PR since I did the work already anyway and you may want to migrate at some point, too.

Laika 1.x is intended to offer long-term API stability, so it's hopefully the last occasion for a long time such a migration step is necessary. Don't get misled by the version numbers, sbt-typelevel and Laika both did a milestone release which turned into an actual RC over time (since no issues could be found so far). We expect little to no changes for the final releases of both. Feel free to either merge this now or park it until the finals are out (in about 2 weeks aprox.) in which case I can update the PR if you want.

Summary of changes:

The build will most likely be red since most of your recent builds on main are red, but I did a few local tests and compared the results to your hosted site (both visually and by comparing HTML sources) and could not easily spot a difference.

noelwelsh commented 11 months ago

Thanks!