search

creativescala / doodle

Compositional vector graphics in Scala / Scala.JS
https://creativescala.org/doodle/
Apache License 2.0
329 stars 76 forks source link

BoundingBox calculation is not stack safe #40

Closed noelwelsh closed 7 years ago

noelwelsh commented 7 years ago

Memoising the calculation at the time of construction, which is stack-safe, should solve the issue.

Need to augment stack safety spec to check for Above / Beside which use bounding box calculations to ensure this is fixed.

noelwelsh commented 7 years ago

Augmented spec doesn't trigger any stack overflows, so closing this until we see one in the wild.