creativetimofficial / blk-design-system-angular

MIT License
70 stars 236 forks source link

[Bug] Blk and angular 10 #6

Open MichalNemec opened 4 years ago

MichalNemec commented 4 years ago

Version

1.0.0

Reproduction link

https://jsfiddle.net/

Operating System

win10

Device

PC

Browser & Version

83.0.4103.116 chrome

Steps to reproduce

  1. create new angular app (10 version)
  2. npm i blk
  3. put scss files in angular.json
  4. watch errors

    What is expected?

    no error

    What is actually happening?

    ERROR in ./node_modules/blk-design-system-angular/src/assets/scss/blk-design-system.scss (./node_modules/css-loader/dist/cjs.js??ref--13-1!./node_modules/postcss-loader/src??embedded!./node_modules/resolve-url-loader??ref--13-3!./node_modules/sass-loader/dist/cjs.js??ref--13-4!./node_modules/blk-design-system-angular/src/assets/scss/blk-design-system.scss) Module build failed (from ./node_modules/sass-loader/dist/cjs.js): SassError: expected "{". ╷ 32 │ background-image: url($file-2x); │ ^ ╵ node_modules\blk-design-system-angular\src\assets\scss\blk-design-system\bootstrap\mixins_image.scss 32:21 @import node_modules\blk-design-system-angular\src\assets\scss\blk-design-system\bootstrap_mixins.scss 8:9 @import D:\webs\x\demo-app\node_modules\blk-design-system-angular\src\assets\scss\blk-design-system.scss 26:9 root stylesheet


Solution

Additional comments

rules200 commented 4 years ago

Me too...

rarestoma commented 4 years ago

Hi @MichalNemec,

Thank you for working with our products.

We are going to start updating our Angular products to Angular 10 at the beginning of the next year, so we recommend waiting until then, so we are going to fix all the issues and verify the products.

I hope it helps.

Thank you, Rares