search

creativetimofficial / ct-impact-design-system-pro

Impact Design System PRO
https://demos.creative-tim.com/impact-design-system-pro/
3 stars 2 forks source link

[Bug] Minified JS != Unminified JS #10

Open smaddock opened 4 years ago

smaddock commented 4 years ago

Version

1.1.0

Reproduction link

https://demos.creative-tim.com/impact-design-system-pro/docs/assets-db/js/dashboard.min.js

Operating System

n/a

Device

n/a

Browser & Version

n/a

Steps to reproduce

  1. gulp build:dist

    What is expected?

    dashboard.min.js to be dynamically generated by gulp from src/dashboard/assets/js/dashboard.js

    What is actually happening?

    Both files are just statically copied, and the existing minified file contains different code than the unminified file, mostly regarding the main nav dropdown, and some tweaks to the map script.

Solution

Use gulp-minify to dynamically generate dist/dashboard/assets/js/dashboard.min.js from src/dashboard/assets/js/dashboard.js

Additional comments

There are a number of other unminified js files included in dist/dashboard/assets/js/ ... those should be included in gulp build:dev and the minified ones in gulp build:dist

zoltanszogyenyi commented 3 years ago

Hello @smaddock,

I'll take a look into this to better manage the modification of the JS files. I've added this to the list of things to be done for version 1.2. Thanks.