search

creativetimofficial / ct-impact-design-system-pro

Impact Design System PRO
https://demos.creative-tim.com/impact-design-system-pro/
3 stars 2 forks source link

[Bug] Missing animate.css in v1.1.0 #14

Open smaddock opened 4 years ago

smaddock commented 4 years ago

Version

1.1.0

Reproduction link

https://www.creative-tim.com/downloads

Operating System

n/a

Device

n/a

Browser & Version

n/a

Steps to reproduce

  1. npm install
  2. gulp build:dist

    What is expected?

    animate.css to be installed via NPM, and included in the dist build by Gulp

    What is actually happening?

    It looks like in the v1.0.0 -> v1.1.0 update, animate.css was not added to package.json... regardless there is no animate.min.css in the dist build.

Solution

Add animate.css to package.json

Additional comments

This file is referenced at https://demos.creative-tim.com/impact-design-system-pro/docs/plugins/notify/ although both the CSS and JS links are to the old v1.0.0 path. Additionally towards the bottom there is a reference to Anime.css ... I'm assuming this is supposed to be animate.css as a web search only shows an Anime.js, no Anime.css.

smaddock commented 4 years ago

It also looks like animate.css needs to be locked to the 3.x build, or the <style> tag needs to be changed to point to the animate.compat.css file.

zoltanszogyenyi commented 3 years ago

Hello @smaddock,

Thanks for the information. I'll take a look into this soon when we will prepare the update for version 1.2.