search

creativetimofficial / ct-impact-design-system-pro

Impact Design System PRO
https://demos.creative-tim.com/impact-design-system-pro/
3 stars 2 forks source link

[Bug] Chart demos included in core JS file #9

Open smaddock opened 4 years ago

smaddock commented 4 years ago

Version

1.1.0

Reproduction link

https://demos.creative-tim.com/impact-design-system-pro/docs/assets-db/js/dashboard.min.js

Operating System

n/a

Device

n/a

Browser & Version

n/a

Steps to reproduce

  1. gulp build:dist on repo

    What is expected?

    dashboard(.min).js contains only production code

    What is actually happening?

    Chart demo data is included in distribution JavaScript file

Solution

Move chart demo data to demo(.min).js

Additional comments

It looks like there is some other demo data in the dashboard script file as well, beyond just the charts, that could be moved to the demo script file.

zoltanszogyenyi commented 3 years ago

Hello @smaddock,

First of all, apologies for the late reply to these issues. For some reason, the email notifications did not come in by simply being a watcher. I'll solve this issue so I can see a new issue added here ASAP.

Regarding this issue, you're right. For version 1.2 we will move these chart demo data to the demo.js file.