creativetimofficial / ct-material-dashboard-pro-laravel

Material Pro Dashboard For Laravel Framework 11.x and Up
https://www.creative-tim.com/live/material-dashboard-pro-laravel
19 stars 6 forks source link

Omissions, errors and typos #4

Closed johnboc closed 5 years ago

johnboc commented 5 years ago

In your documentation under Build Tools you say: "You can set in gulpfile.js from your downloaded archive any page you want to open in browser, at line 30: gulp.src('examples/dashboard.html')." But in the material-dashboard-pro-laravel-v1.0.0.zip there is not a gulpfile.js in the project folder.

There is an undefined variable: classPage in View: resources\views\layouts\page_templates\guest.blade.php and I cannot see how to fix this.

In resources\views\profile\edit.blade.php line 63 and 107 have a typo. It should be {{ ('Update Profile') }} and {{ ('Change password') }} and not {{ ('Update Profile') }} or {{ ('Change password') }}

eugentudorache commented 5 years ago

Hello @johnboc, the Build Tools docs page is only related to the frontend assets of the theme.

We'll check the issue and follow up soon, thank you!

Eugen

eugentudorache commented 5 years ago

Hello @johnboc We cannot reproduce the error. Can you please describe all the user steps you are going through to encounter the error?

Thank you Eugen

johnboc commented 5 years ago

Download material-dashboard-pro-laravel-v1.0.0.zip and install and build. Login and go to /profile and it generates the following error. The typos on referenced in my initial post. typo_error

I need more time to recreate the undefined variable: classPage error

Ghitu commented 5 years ago

Hello again. Thank you for your support. We fixed the issue and pushed the fix. You can download the archive from Creative Tim website again.

Best Alin

johnboc commented 5 years ago

undefined variable: classPage error My index.blade.php is

@extends('layouts.app', ['activePage' => 'exhibitions', 'menuParent' => 'laravel', 'titlePage' => __('Exhibitions')])

@section('content') 
 . . .
@endsection

If the route Route::resource('exhibition', 'ExhibitionController'); is outside of Route::group(['middleware' => 'auth'], function () { } I get the error. I don't get the error when it's within the group. I can't see why this blade needs the classPage variable set when it's not in the Route:group.

Ghitu commented 5 years ago

Hello @johnboc

The variable classPage is used in the page_templates/guest.blade.php view which is used for guest pages (when user is not authenticated). When you move the route from auth midleware and your user is not authenticated, the app tries to use guest.blade.php templates which generates the error.

Best Alin

johnboc commented 5 years ago

Ok understood. Thanks