search

creativetimofficial / ct-now-ui-dashboard-pro-react

React version of Now UI Dashboard PRO
23 stars 5 forks source link

Modal is Buggy #17

Closed kunaljaypatel closed 4 years ago

kunaljaypatel commented 5 years ago

Prerequisites

Please answer the following questions for yourself before submitting an issue.

Expected Behavior

The Modal appears in the correct location on every presentation.

Current Behavior

Sometimes the Modal does not appear in the correct location. (https://imgur.com/a/53GNcAr)

Failure Information (for bugs)

The Modal in Now-Ui-Dashboard-react is buggy on Safari. A portion of it sometimes gets cut off in the Safari Browser on presentation.

Steps to Reproduce

Use Safari Browser.

  1. Navigate to the premade Notifications page.
  2. Click "Notice Modal", then click "small alert modal". Keep clicking, opening, and repeating this process until you notice that one of the modals doesn't appear properly and gets stuck while cut off.

Context

Occurs on Safari. The code is the default code that comes with the latest version of Now-UI Dashboard Pro React.

Failure Logs

N/A

einazare commented 5 years ago

Hello again, @kunaljaypatel ,

I'll take a look at this in a few days. Right now I am away with some personal matters.

Best, Manu

kunaljaypatel commented 5 years ago

Hey @EINazare ,

Have you had a chance to look at it?

I tried debugging it a few days ago, and I was able to figure out a solution. If you turn fade={false} in the Modal, the Modal doesn't get "stuck". I assume the animation is just bugged on Safari with now-ui-dashboard-pro-react.

I went to ReactStrap and tried their modals (on Safari). It works consistently there with fade={true}. I'm not sure what's causing the animation to get "stuck" on now-ui-dashboard-pro-react .

Let me know if you have any issues reproducing the bug.

Thanks,

Kunal

einazare commented 5 years ago

Hello again @kunaljaypatel ,

Sorry for this late response. Last few weeks have been a chaos. I've tested it and haven't been able to reproduce your issue. I've actually tested on the same device as you.

screen shot 2018-12-11 at 10 52 06 am

Now sure how to help you.

Best, Manu

kunaljaypatel commented 5 years ago

Hi Manu,

No problem. I'll investigate further at a later time, but for now I'm satisfied with the workaround.

Thanks.