creativetimofficial / ct-now-ui-kit-pro

Now UI Kit PRO - Premium Bootstrap 4 UI Kit

https://www.creative-tim.com/product/now-ui-kit-pro

39 stars 17 forks source link

Carousel component ignores data-interval="false" #31

Open cregx opened 6 years ago

cregx commented 6 years ago

Prerequisites

[x] I am running the latest version 1.2.2 (Now UI Kit Pro)
[x] I checked the documentation and found no answer
[x] I checked to make sure that this issue has not already been filed

Expected Behavior

When setting data-interval to "false" I expect that no automatic start of the carousel is performed.

Current Behavior

The carousel component always runs - even if I use false.

Failure Information

Steps to Reproduce

Use these values: <div class="carousel slide" data-ride="carousel" data-type="multi" data-interval="false" id="productCarousel">
Test the behavior: the carousel starts automatically.
Replace the bootstrap.min.js with the latest master and check the behavior again: the carousel does not start automatically.
Change the data-interval setting from "false" to e.g. "8000" and vice versa to evaluate the test.

dragosct commented 6 years ago

Hi, @cregx! Thank you for using our products. This is happening because in your project folder in assets/js/now-ui-kit.js file you have in ready function the following lines of code:

$('.carousel').carousel({
        interval: 4000
    });

To fix the problem please remove the interval option.

Regards, Dragos