creativetimofficial / light-bootstrap-dashboard

Light Bootstrap Dashboard is an admin dashboard template designed to be beautiful and simple.
https://www.creative-tim.com/product/light-bootstrap-dashboard
MIT License
1.35k stars 709 forks source link

[PRO] What is actually in jquery-ui - what is perfectScrollbar #23

Open nzjrs opened 7 years ago

nzjrs commented 7 years ago

I have another version of my application that depends on jquery-ui, but needs parts that were not included in your minified version, so I wanted to generate a new jquery-ui.min.js with this feature. Then I realised that it looks like you have minified perfectScrollbar inside jquery-ui.min.js.

Why have you done this? or am I mistaken. Which version of perfectScrollbar have you minified in there?

It would be good if you kept jquery-ui.min.js exactly as that as downloaded from https://jqueryui.com/download/#!version=1.11.4

alexandru-paduraru commented 7 years ago

@nzjrs thank you for using our product. We wanted to keep the scripts as easy to be used and not to import too many files when you work. So we added the perfect-scrollbar library there, we later realised that that is not the right way and we have to use each library separate, no matter how many files the end user will have.

We have in our releases plan to remove the PS from jQuery ui and keep it on its own file. From what we know we were using the v0.6.4 of PS.

Now for the other question. PerfectScrollbar is a library that is activating only when you are on windows and it's creating a better scrollbar for your page, it's removing the ugly scroll from windows. More here: http://noraesae.github.io/perfect-scrollbar/