creativetimofficial / material-kit

Free and Open Source UI Kit for Bootstrap 5, React, Vue.js, React Native and Sketch based on Google's Material Design
https://www.creative-tim.com/product/material-kit?ref=mk-creativetimofficial-github
MIT License
5.91k stars 1.35k forks source link

scss not working on rails (5) #106

Closed michelson closed 6 years ago

michelson commented 6 years ago

just copied the files and add it to application.scss

@import "scss/material-kit-pro.scss";

lot sass of errors!! im using pro kit

dragosct commented 6 years ago

Hi, @michelson! Thank you for using our product. What errors did you have? Regards, Dragos.

feliksby commented 6 years ago

same here! A lot of errors!!

krabique commented 6 years ago

There seem to be a problem with missing /material-kit/assets/img/arrow-left.cur and /material-kit/assets/img/arrow-left.png. Both .css and .scss won't resolve those arrow assets (they are simply not there). Same for arrow-right. I'm using the free npm package and loading it through webpacker gem.

UPD: I would think the problem is caused by this code in /material-kit/assets/scss/core/_carousel.scss

        .left{
            cursor: url("../img/arrow-left.png"), url("../img/arrow-left.cur"), default !important;
        }
        .right{
            cursor: url("../img/arrow-right.png"), url("../img/arrow-right.cur"), default !important;
        }

there is no img directory, neither in /material-kit/assets/scss/core/, nor in /material-kit/assets/scss/

michelson commented 6 years ago

well, it should be easy for you guys to put the scss files info the rails asset pipeline and execute rails s, don't expect that people who bought your product reproduce the bug for you. It a shame that this has been reported 20 days ago and we have no responses yet ??.

I've been able to fix this by commenting & rewriting some of the sass code , it has to be with the compiler complaining with nested & , and other stuff, but just @import "scss/material-kit-pro.scss" into a blank rails project and try it out!

alexandru-paduraru commented 6 years ago

@michelson please open the issue on the PRO repo (https://github.com/creativetimofficial/material-kit-pro/issues/new), in this way you will get a better priority for our support. At this moment our Free products are used by hundreds of thousands of people and we have a lot of developers requesting/reporting a lot of things. This is the reason we split the repos in Free/PRO to better server those with PRO.

We were doing a lot of changes from BS3 to BS4 in the structure of the product in order to comply with the latest Bootstrap rules. Sorry for the inconvenience, we will have a fix on this soon.

Best, Alex

bbuehrle commented 6 years ago

I have the same issue using symfony 4 and webpack-encore. I'm assuming that the webpacker gem is probably the same thing, but works with symfony. I'm still new and I haven't fully tested, but the work-around that I came up with for now is to comment out carousel.scss from the main .scss file if you aren't using the carousel.

@alexandru-paduraru I have to disagree with your "better support" comment. I hadn't seen this issue before I submitted mine in the PRO repo 16 DAYS ago, but even with spending money on this kit I still haven't received a single comment. I'm hoping that referencing it her on the free repo, it will draw more attention. creativetimofficial/material-kit-pro#63

alexandru-paduraru commented 6 years ago

@bbuehrle sorry to hear that :-( I've checked and I've seen that you don't have a response there either. We are looking into this and come back with a solution for you tomorrow.

dragosct commented 6 years ago

Hi, @michelson! We are sorry for the late response. Now we tried to compile the scss with the rails app and yes there are errors. Did you fixed the errors, because I saw that you said that you fixed them? I've checked the errors and I fixed them so If you want I can send you the new scss folder to see if you still receive the errors.

Regards, Dragos

michelson commented 6 years ago

Hi Dragos , that would be great

thanks!

Atte. Miguel Michelson Martinez www.vadb.org http://vadb.org

On Thu, Mar 1, 2018 at 9:47 AM, dragosct notifications@github.com wrote:

Hi, @michelson https://github.com/michelson! We are sorry for the late response. Now we tried to compile the scss with the rails app and yes there are errors. Did you fixed the errors, because I saw that you said that you fixed them? I've checked the errors and I fixed them so If you want I can send you the new scss folder to see if you still receive the errors.

Regards, Dragos

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/creativetimofficial/material-kit/issues/106#issuecomment-369580973, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAuyFQMfvj7iSReX7bEfLtn8ixAMLCMks5tZ-3QgaJpZM4R4MkF .

dragosct commented 6 years ago

Great! Please, give me your email to give you the dropbox link because here it's a public repo and I can't. Regards, Dragos

michelson commented 6 years ago

I've sen't you an email to dragos@creative-tim.com , thanks

robertocarvajal commented 6 years ago

I had the same problem with symfony and encore, I was able to find the missing arrow files browsing older versions of this repo, if everyone else needs them they can be downloaded from here

https://github.com/creativetimofficial/material-kit/tree/6d5e73894a6249e7081516def43e4d73cabcdb92/assets/img

once I put the files encore failed because it doesn't know how to handle .cur files but that's other issue, I just commented those out and it worked fine after that ;)

mehdibaha commented 6 years ago

Please fix this ASAP, as we can't have a working version-controlled package.json if the css contains bugs...

dragosct commented 6 years ago

Hi, @mehdibaha! Thank you for using our product. We will release an update for the material kit soon. Regards, Dragos

KgotsoK commented 6 years ago

Has this been fixed?

Im using Angular 6, used npm to pull in the material-kit package, but /node_modules/material-kit/assets/img does not contain arrow-right.cur , arrow-right.png, arrow-left.cur and arrow-left.png. I mean this seems pretty straight-forward to fix doesn't it?