creativetimofficial / now-ui-kit

Now UI Kit Bootstrap 4 - Designed by Invision. Coded by Creative Tim
https://www.creative-tim.com/product/now-ui-kit
Other
1.7k stars 376 forks source link

Error after upgrading to LibSass v3.6.3 #100

Open brunoamaral opened 4 years ago

brunoamaral commented 4 years ago

Prerequisites

Please answer the following questions for yourself before submitting an issue.

Expected Behavior

Successful build of CSS

Current Behavior

/now-ui/assets/scss/now-ui-kit/mixins/_navbar.scss", line 2, col 5: Top-level selectors may not contain the parent selector "&".

Failure Information (for bugs)

Please help provide information about the failure if this is a bug. If it is not a bug, please remove the rest of this template.

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. run the build command with LibSass (v3.6.3).

Context

I noticed this after upgrading to Hugo, a static site generator written in Golang.

Failure Logs

dragosct commented 4 years ago

Hi, @brunoamaral! Thank you for using our products. Have you tried to fix the problem directly from the source to eliminate the selector &?

Regards, Dragos

brunoamaral commented 4 years ago

Yes I did @dragosct10, and it worked.

Given that I don't know all the implications of that change, I figured it was best to let you guys know what was going on.