creativetimofficial / now-ui-kit

Now UI Kit Bootstrap 4 - Designed by Invision. Coded by Creative Tim
https://www.creative-tim.com/product/now-ui-kit
Other
1.7k stars 376 forks source link

[Bug] Disabled buttons appear active on hover #104

Open stebogit opened 4 years ago

stebogit commented 4 years ago

Version

1.3

Reproduction link

https://demos.creative-tim.com/now-ui-kit/docs/1.0/components/buttons.html#disabled-state

Operating System

MAC OS

Device

MacBook

Browser & Version

Any

Steps to reproduce

just load your docs page and hover over any disabled button

What is expected?

hovering over a disabled button should not trigger any color/state change

What is actually happening?

the color and the element shadow are changing like they were active


Solution

apply the right color to disabled buttons https://github.com/creativetimofficial/now-ui-kit/blob/master/assets/css/now-ui-kit.css#L1731-L1732

and removed opacity applied to any .btn:hover https://github.com/creativetimofficial/now-ui-kit/blob/master/assets/css/now-ui-kit.css#L1603

Additional comments